Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from noir #5416

Merged
merged 5 commits into from
Mar 25, 2024
Merged

feat: Sync from noir #5416

merged 5 commits into from
Mar 25, 2024

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(github): Improve PR template "document later" checkbox description (noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using from_integer (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting string[x] = ".." (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
END_COMMIT_OVERRIDE

AztecBot and others added 5 commits March 25, 2024 11:39
@AztecBot
[1 changes] chore(github): Improve PR template "document later" check…
2eacc76 
…box description (noir-lang/noir#4625)

chore: Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
@sirasistant
chore: fix broken contracts with new noir
123433e
@sirasistant
Merge branch 'master' into sync-noir
121dc7b
@sirasistant
fix: contract deployer hashing
63bb11e
@sirasistant
test: fix var args test
1585a2c
@AztecBot
Copy link
Collaborator Author

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (private-kernel-inner): 309 (-49%)
  • circuit_simulation_time_in_ms (public-kernel-app-logic): 126 (-68%)
  • tx_pxe_processing_time_ms (0): 2,354 (-21%)
  • tx_sequencer_processing_time_ms (1): 734 (-35%)
  • tx_size_in_bytes (0): 14,966 (-32%)
  • l2_block_building_time_in_ms (8): 13,881 (-18%)
  • l2_block_building_time_in_ms (32): 51,504 (-20%)
  • l2_block_building_time_in_ms (64): 102,101 (-20%)
  • l2_block_public_tx_process_time_in_ms (8): 5,895 (-35%)
  • l2_block_public_tx_process_time_in_ms (32): 23,319 (-35%)
  • l2_block_public_tx_process_time_in_ms (64): 46,499 (-35%)
  • note_trial_decrypting_time_in_ms (32): 100 (+267%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9e05e9c7 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,412 (+1%) 6,424 6,424
l1_rollup_execution_gas 585,745 585,757 585,757
l2_block_processing_time_in_ms 1,230 (-6%) 4,698 (-3%) 8,977 (-2%)
note_successful_decrypting_time_in_ms 184 582 (+14%) 970 (-2%)
note_trial_decrypting_time_in_ms 87.4 (+1%) ⚠️ 100 (+267%) 98.3 (-19%)
l2_block_building_time_in_ms ⚠️ 13,881 (-18%) ⚠️ 51,504 (-20%) ⚠️ 102,101 (-20%)
l2_block_rollup_simulation_time_in_ms 7,964 (+1%) 28,137 55,502 (+1%)
l2_block_public_tx_process_time_in_ms ⚠️ 5,895 (-35%) ⚠️ 23,319 (-35%) ⚠️ 46,499 (-35%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,148 (+3%) 27,363 (-1%)
note_history_successful_decrypting_time_in_ms 1,265 (+5%) 2,476 (+1%)
note_history_trial_decrypting_time_in_ms 100 (+51%) 151 (+2%)
node_database_size_in_bytes 18,661,456 35,086,416
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 236 44,377 28,214
private-kernel-ordering 209 (-1%) 52,880 14,296
base-parity 4,697 (+5%) 128 311
root-parity 1,680 (+6%) 1,244 311
base-rollup 18,000 (+1%) 165,760 861
root-rollup 50.2 (+1%) 4,359 725
private-kernel-inner ⚠️ 309 (-49%) 73,794 28,214
public-kernel-app-logic ⚠️ 126 (-68%) 35,251 28,217
public-kernel-tail 170 (-1%) 40,928 28,217
merge-rollup 8.07 2,568 861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.0 (+1%) 15.9 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.584 (+1%) 0.493 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 47.1 (+1%) 72.5 (+1%) 230 (-1%) 446 866 (-1%) 1,717 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.483 (+1%) 0.448 (+1%) 0.419 (-1%) 0.417 0.413 0.412 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 55.0 (+2%) 107 (+1%) 333 (-1%) 662 1,305 2,602 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.489 (+2%) 0.483 (+1%) 0.455 0.456 0.454 0.453 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.4
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.539

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes ⚠️ 14,966 (-32%) 494,914

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms ⚠️ 2,354 (-21%) 1,407 (-13%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 19.1 (+13%) ⚠️ 734 (-35%)

@sirasistant sirasistant merged commit 13a12d5 into master Mar 25, 2024
130 checks passed
@sirasistant sirasistant deleted the sync-noir branch March 25, 2024 16:19
AztecBot added a commit to noir-lang/noir that referenced this pull request Mar 25, 2024
@AztecBot @sirasistant
feat: Sync from noir (AztecProtocol/aztec-packages#5416)
05c2eaa 
Automated pull of development from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore(github): Improve PR template "document later" checkbox description
(#4625)
chore: Update integers.md to note support for Fields using
`from_integer` (#4536)
chore: update docs with function names to match version 0.25.0
specifications (#4466)
feat: add specific error for attempting `string[x] = ".."`
(#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation
(#4610)
END_COMMIT_OVERRIDE

---------

Co-authored-by: sirasistant <[email protected]>
@AztecBot AztecBot mentioned this pull request Mar 25, 2024
Closed
TomAFrench added a commit that referenced this pull request Mar 25, 2024
@TomAFrench
Merge branch 'master' into gd/noir_issue_4330
7447259 
* master:
  fix: Broadcasting unconstrained function with empty sibling (#5429)
  feat: Sync from noir (#5416)
  refactor: Meld flavor and and circuit builder modules (#5406)
  feat: less earthly runners + e2e GA runners, bb bench (#5356)
  fix: Track class registered count in tx stats (#5417)
@spalladino spalladino mentioned this pull request Mar 25, 2024
Closed
This was referenced Mar 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunkar Thunkar Thunkar approved these changes

@spalladino spalladino Awaiting requested review from spalladino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AztecBot @Thunkar @sirasistant